am i doing this right in Models