am i doing it right in Models